Skip to content

Optimize spanner migration handler #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Optimize spanner migration handler #1282

wants to merge 4 commits into from
+1,681 −285

Conversation

yad-unext
Copy link

@yad-unext yad-unext commented May 30, 2025 •
edited
Loading

Main objectives:

  • Remove comments: spanner does allow comments in DDL. The previous way doesn't support graph syntax.
  • Split DDL into statements: spanner requires the migration request to be a list of statements, not a single DDL file.
    Because each request is not allowed to exceed 10 statements.

@coveralls
Copy link

coveralls commented May 30, 2025 •
edited
Loading

Coverage Status

coverage: 56.506% (+0.2%) from 56.314%
when pulling 2e5cea8 on u-next:optimize-spanner
into 2788339 on golang-migrate:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yad-unext @coveralls